reuse visitField for conversions on intermediate types#52
Merged
nathanhhughes merged 2 commits intomainfrom Jul 18, 2025
Merged
reuse visitField for conversions on intermediate types#52nathanhhughes merged 2 commits intomainfrom
nathanhhughes merged 2 commits intomainfrom
Conversation
Schmluk
approved these changes
Jul 9, 2025
Collaborator
Schmluk
left a comment
Schmluk
left a comment
There was a problem hiding this comment.
LGTM! I didn't check all input info in the greatest detail but looks correct from a first pass. Not sure input info for conversions is covered in the other tests but again looks correct from a first pass.
|
|
||
| // Non-config types with a conversion. | ||
| template <typename Conversion, typename T, typename std::enable_if<!isConfig<T>(), bool>::type = true> | ||
| // Types with a extra conversion. |
Collaborator
There was a problem hiding this comment.
Nice! Always good to have less constraints. 🙂
nathanhhughes
force-pushed
the
feature/better_conversions
branch
2 times, most recently
from
10c86ba to
0cb4b7f
Compare
nathanhhughes
force-pushed
the
feature/better_conversions
branch
from
0cb4b7f to
a33024e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to how conversions are handled to deal with the issue I was showing you. Mostly straightforward though I had to change
getFieldInputInfoslightly. I think my solution works but idk if you can see a cleaner way to handle it (there's some implicit state from howvisitFieldgets called that is hard to reason about)